Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update r notebook #1122

Merged
merged 1 commit into from
Aug 24, 2021
Merged

update r notebook #1122

merged 1 commit into from
Aug 24, 2021

Conversation

adamgayoso
Copy link
Member

No description provided.

@codecov
Copy link

codecov bot commented Aug 24, 2021

Codecov Report

Merging #1122 (c387d36) into master (302e1ac) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1122   +/-   ##
=======================================
  Coverage   90.12%   90.12%           
=======================================
  Files          93       93           
  Lines        7300     7300           
=======================================
  Hits         6579     6579           
  Misses        721      721           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 302e1ac...c387d36. Read the comment docs.

@adamgayoso adamgayoso merged commit 757bc96 into master Aug 24, 2021
@adamgayoso adamgayoso deleted the update_r_notebook branch August 24, 2021 16:22
@watiss
Copy link
Contributor

watiss commented Sep 1, 2021

@meeseeksdev backport to 0.14.0-test

@lumberbot-app
Copy link

lumberbot-app bot commented Sep 1, 2021

Can't Dooooo.... It seem like this is already backported (commit is empty).I won't do anything. MrMeeseeks out.

@watiss
Copy link
Contributor

watiss commented Sep 1, 2021

@meeseeksdev backport to test

@lumberbot-app
Copy link

lumberbot-app bot commented Sep 1, 2021

Something went wrong ... Please have a look at my logs.

It seem that the branch you are trying to backport to does not exists.

@watiss
Copy link
Contributor

watiss commented Sep 1, 2021

@meeseeksdev backport to test

@lumberbot-app
Copy link

lumberbot-app bot commented Sep 1, 2021

Something went wrong ... Please have a look at my logs.

It seem that the branch you are trying to backport to does not exists.

@watiss
Copy link
Contributor

watiss commented Sep 1, 2021

@meeseeksdev backport to adam/neural_deconv

@lumberbot-app
Copy link

lumberbot-app bot commented Sep 1, 2021

Something went wrong ... Please have a look at my logs.

It seem that the branch you are trying to backport to does not exists.

@watiss
Copy link
Contributor

watiss commented Sep 1, 2021

@meeseeksdev backport to testtest

@lumberbot-app
Copy link

lumberbot-app bot commented Sep 1, 2021

Something went wrong ... Please have a look at my logs.

It seem that the branch you are trying to backport to does not exists.

@watiss
Copy link
Contributor

watiss commented Sep 1, 2021

@meeseeksdev backport to msdtest

@lumberbot-app
Copy link

lumberbot-app bot commented Sep 1, 2021

Something went wrong ... Please have a look at my logs.

@watiss
Copy link
Contributor

watiss commented Sep 1, 2021

@meeseeksdev backport to msdtest

@lumberbot-app
Copy link

lumberbot-app bot commented Sep 1, 2021

Something went wrong ... Please have a look at my logs.

@Carreau
Copy link

Carreau commented Sep 2, 2021

Responding to scientific-python/MeeseeksDev#52,

It looks like you deleted the target branch Here is the errors I get in the logs:


Sep 02 01:14:59 meeseeksbot app/web.1 Traceback (most recent call last):
Sep 02 01:14:59 meeseeksbot app/web.1   File "/app/.heroku/python/lib/python3.7/site-packages/tornado/web.py", line 1697, in _execute
Sep 02 01:14:59 meeseeksbot app/web.1     result = method(*self.path_args, **self.path_kwargs)
Sep 02 01:14:59 meeseeksbot app/web.1   File "/app/meeseeksdev/meeseeksbox/core.py", line 234, in post
Sep 02 01:14:59 meeseeksbot app/web.1     return self.dispatch_action(action, payload)
Sep 02 01:14:59 meeseeksbot app/web.1   File "/app/meeseeksdev/meeseeksbox/core.py", line 324, in dispatch_action
Sep 02 01:14:59 meeseeksbot app/web.1     self.dispatch_on_mention(body, payload, user)
Sep 02 01:14:59 meeseeksbot app/web.1   File "/app/meeseeksdev/meeseeksbox/core.py", line 607, in dispatch_on_mention
Sep 02 01:14:59 meeseeksbot app/web.1     local_config=local_config,
Sep 02 01:14:59 meeseeksbot app/web.1   File "/app/meeseeksdev/meeseeksbox/commands.py", line 701, in safe_backport
Sep 02 01:14:59 meeseeksbot app/web.1     repo.remotes.origin.fetch("refs/heads/{}:workbranch".format(target_branch))
Sep 02 01:14:59 meeseeksbot app/web.1   File "/app/.heroku/python/lib/python3.7/site-packages/git/remote.py", line 790, in fetch
Sep 02 01:14:59 meeseeksbot app/web.1     res = self._get_fetch_info_from_stderr(proc, progress)
Sep 02 01:14:59 meeseeksbot app/web.1   File "/app/.heroku/python/lib/python3.7/site-packages/git/remote.py", line 674, in _get_fetch_info_from_stderr
Sep 02 01:14:59 meeseeksbot app/web.1     proc.wait(stderr=stderr_text)
Sep 02 01:14:59 meeseeksbot app/web.1   File "/app/.heroku/python/lib/python3.7/site-packages/git/cmd.py", line 412, in wait
Sep 02 01:14:59 meeseeksbot app/web.1     raise GitCommandError(self.args, status, errstr)
Sep 02 01:14:59 meeseeksbot app/web.1 git.exc.GitCommandError: Cmd('git') failed due to: exit code(1)
Sep 02 01:14:59 meeseeksbot app/web.1   cmdline: git fetch -v origin refs/heads/msdtest:workbranch

running the commands manually on the same box works, so from the top of my head I'm not sure what is happening.

@Carreau
Copy link

Carreau commented Sep 2, 2021

So I'm not too sure, maybe the bot fell into an inconsistent state. I've rebooted it – hopefully this will work.

My guess is maybe one of the first attempt created a workbranch that did not get cleaned up. I try to not erase the branches too often as the drive is slow on heroku and cloning can takes minutes for large repo like matplotlib.

you can retry see if it work, if not i'll add more debug capabilities.

@watiss
Copy link
Contributor

watiss commented Sep 2, 2021

@meeseeksdev backport to msdtest2

meeseeksmachine pushed a commit to meeseeksmachine/scvi-tools that referenced this pull request Sep 2, 2021
@watiss
Copy link
Contributor

watiss commented Sep 2, 2021

@Carreau Thanks, I think I got it to work. It might be that I was doing it wrong, because I was branching off of a commit that was part of this PR that I was trying to backport (we dont squash commits when we merge, we should probably fix that). That might have been the reason why the bot was failing. Or it might be that the bot was in a bad state. We might never know :)

Two more things though:

  • Do you still need to whitelist repo's for using MeeseeksDev bot? If so, could you whitelist scvi-tools? @adamgayoso as FYI
  • Must we always have a milestone with an "on-merge" comment to get the bot to backport or is a comment on the merged PR enough?

@Carreau
Copy link

Carreau commented Sep 2, 2021

  • Do you still need to whitelist repo's for using MeeseeksDev bot? If so, could you whitelist scvi-tools?

No, every repo is allowed, there is no block list, or allow list.

  • Must we always have a milestone with an "on-merge" comment to get the bot to backport or is a comment on the merged PR enough

Either a milestone or a label with on-merge:, I haven't implemented comments though it would be doable.
One of the issue is that scanning all PRs comments would consume a lot of requests and I'm limited to 5000/hours.

It might be that I was doing it wrong,

Nah, likely a bug on my side and caching gone wrong. Cloning repo like matplotlib takes forever so I have optimization to always work on the same git repo and it's not the first time they fail. Also some cleanup happens only every 24h or so when the bot restart, so it might be it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants