Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Copy the scvi state dict during SCANVI initialization to prevent it from being overwritten within scvi_model #1284

Merged
merged 2 commits into from Dec 3, 2021

Conversation

watiss
Copy link
Contributor

@watiss watiss commented Dec 2, 2021

Fixes #1283

@codecov
Copy link

codecov bot commented Dec 2, 2021

Codecov Report

Merging #1284 (415b0e6) into master (7d9e9f7) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1284   +/-   ##
=======================================
  Coverage   90.69%   90.69%           
=======================================
  Files          96       96           
  Lines        7766     7766           
=======================================
  Hits         7043     7043           
  Misses        723      723           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7d9e9f7...415b0e6. Read the comment docs.

scvi/model/_scanvi.py Outdated Show resolved Hide resolved
@watiss watiss merged commit c01cb29 into master Dec 3, 2021
@watiss watiss deleted the valehvpa/scanvi_init_fix branch December 3, 2021 21:59
@adamgayoso
Copy link
Member

@meeseeksdev backport to 0.14.x

meeseeksmachine pushed a commit to meeseeksmachine/scvi-tools that referenced this pull request Dec 3, 2021
…itialization to prevent it from being overwritten within `scvi_model`
adamgayoso pushed a commit that referenced this pull request Dec 5, 2021
…ation to prevent it from being overwritten within `scvi_model` (#1287)

Co-authored-by: Valeh Valiollah Pour Amiri <4193454+watiss@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Scanvi should copy scvi state dict on initialization
2 participants