Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

glossary #999

Merged
merged 4 commits into from Mar 20, 2021
Merged

glossary #999

merged 4 commits into from Mar 20, 2021

Conversation

adamgayoso
Copy link
Member

Fixes #995

@codecov
Copy link

codecov bot commented Mar 10, 2021

Codecov Report

Merging #999 (deabc31) into master (57c992a) will decrease coverage by 0.03%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #999      +/-   ##
==========================================
- Coverage   89.72%   89.69%   -0.04%     
==========================================
  Files          87       87              
  Lines        6182     6190       +8     
==========================================
+ Hits         5547     5552       +5     
- Misses        635      638       +3     
Impacted Files Coverage Δ
scvi/_settings.py 87.91% <0.00%> (-2.45%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 57c992a...deabc31. Read the comment docs.

.. tab:: TrainingPlan


The training plan is a PyTorch Lightning Module that is initializd with a scvi-tools module object.
Copy link
Contributor

@galenxing galenxing Mar 18, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
The training plan is a PyTorch Lightning Module that is initializd with a scvi-tools module object.
The TrainingPlan is a PyTorchLightning Module that is initialized with a scvi-tools Module object.

It configures the optimizers, defines the training step and validation step, and computes metrics to be
recorded during training. The training step and validation step are functions that take data, run it through
the model and return the loss, which will then be used to optimize the model parameters in the Trainer.
Overall, training plans can be used to develop complex inference schemes on top of modules.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Overall, training plans can be used to develop complex inference schemes on top of modules.
Overall, child classes of TrainingPlan can be used to develop complex inference schemes on top of modules.


.. tab:: Model

A model class is a user-facing object that contains the module as an attribute (i.e., ``self.module``).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
A model class is a user-facing object that contains the module as an attribute (i.e., ``self.module``).
A Model class inherits :class:`~scvi.model.base.BaseModelClass` and is the user-facing object for interacting with a Module.

Comment on lines +31 to +35
The model has a `train` method that learns the parameters of the module, and also contains methods
for users to retrieve information from the module, like the latent representation of cells in a VAE.
Conventionally, the post-inference model methods should not store data into the AnnData object, but
instead return "standard" Python objects, like numpy arrays or pandas dataframes.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
The model has a `train` method that learns the parameters of the module, and also contains methods
for users to retrieve information from the module, like the latent representation of cells in a VAE.
Conventionally, the post-inference model methods should not store data into the AnnData object, but
instead return "standard" Python objects, like numpy arrays or pandas dataframes.
The Model has a `train` method that learns the parameters of the Module, and also contains methods
for users to retrieve information from the Module, like the latent representation of cells in a VAE.
Conventionally, a Model's post-inference methods should not store data into the AnnData object, but
instead return "standard" Python objects, like a numpy array or a pandas DataFrame.


.. tab:: Module

A module is the lower-level object that defines a generative model and inference scheme. A module will
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
A module is the lower-level object that defines a generative model and inference scheme. A module will
A Module is the lower-level object that defines a generative model and inference scheme. A Module will


A module is the lower-level object that defines a generative model and inference scheme. A module will
either inherit :class:`~scvi.module.base.BaseModuleClass` or :class:`~scvi.module.base.PyroBaseModuleClass`.
Consequently, a module can either be implemented with PyTorch alone, or Pyro. In the PyTorch only case, the
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Consequently, a module can either be implemented with PyTorch alone, or Pyro. In the PyTorch only case, the
Consequently, a Module can either be implemented with PyTorch alone, or Pyro. In the PyTorch only case, the

adamgayoso and others added 2 commits March 17, 2021 19:20
Co-authored-by: Galen Xing <gx2113@columbia.edu>
@adamgayoso adamgayoso merged commit 4041aa5 into master Mar 20, 2021
@adamgayoso adamgayoso deleted the glossary branch March 20, 2021 17:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add glossary to developer guide
2 participants