Skip to content
This repository has been archived by the owner on Nov 4, 2021. It is now read-only.

using dos2unix instead of changing git global setting? #81

Open
sylefeb opened this issue Jul 3, 2021 · 1 comment
Open

using dos2unix instead of changing git global setting? #81

sylefeb opened this issue Jul 3, 2021 · 1 comment

Comments

@sylefeb
Copy link

sylefeb commented Jul 3, 2021

Hi, great repo! I wanted to make a suggestion regarding the following in the yices2 script:

# TODO: handle this better so I don't mess with people's dev envs
git config --global core.autocrlf false

As a Windows/mingw/cygwin user I definitely would not want my global git autocrlf changed. Maybe it would be possible to use dos2unix which at least on msys2 (mingw) can be installed easily (pacman -S dos2unix)?

Hope this helps -

@edbordin
Copy link
Collaborator

edbordin commented Jul 5, 2021

Hi, I haven't been putting a lot of effort into this any more as I think it's largely superseded by https://github.com/YosysHQ/oss-cad-suite-build. This issue is only really a problem if you're running the scripts locally for development, but I agree it's not ideal. I do apologise that I never resurrected the windows build (perhaps you were looking into fixing that yourself) but a couple of the tools enabled link-time optimisation (LTO) upstream which is broken on mingw64 and it looked like it would be a reasonable amount of effort to turn LTO off in these builds...

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants