interchange: add FASM generation target and clean-up tests #678
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
acomodi
force-pushed
the
initial-fasm-generation
branch
2 times, most recently
from
f848855
to
6beb1a3
Compare
gatecat
reviewed
Apr 14, 2021
| --family ${device_family} | ||
| ${device_loc} | ||
| ${netlist} | ||
| ${phys} > ${fasm} |
There was a problem hiding this comment.
doing redirection like this tends to cause problems if the FASM generator hits an error, as an empty file will be created and so make won't automatically re-run the fasm generator when running the makefile again.
I think the best option here is to add an output file argument to the FASM generator.
There was a problem hiding this comment.
Right, I'll make the corresponding changes to the FASM generator and update this once the new tag is there
Signed-off-by: Alessandro Comodi <acomodi@antmicro.com>
Signed-off-by: Alessandro Comodi <acomodi@antmicro.com>
acomodi
force-pushed
the
initial-fasm-generation
branch
from
6beb1a3
to
ea9e12b
Compare
acomodi
changed the title
gatecat
approved these changes
Apr 14, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Alessandro Comodi acomodi@antmicro.com
This PR adds a target to generate the FASM output.