Formatting of python code #109
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sbysrc/sby.py
Outdated
| early_log(my_workdir, "Moving directory '{}' to '{}'.".format(my_workdir, "{}.bak{:03d}".format(my_workdir, backup_idx))) | ||
| early_log( | ||
| my_workdir, "Moving directory '{}' to '{}'.".format(my_workdir, | ||
| "{}.bak{:03d}".format(my_workdir, backup_idx))) |
There was a problem hiding this comment.
Some of these ways how it breaks long lines are really awkward. Are you sure this is an improvement?
There was a problem hiding this comment.
break is on 120 chars per line (same as in nextpnr c++ code), split of line have lot of configuration possibilities (check .style.yapf ) but agree some are even looking strange a standard way of formatting python.
There was a problem hiding this comment.
120 chars per line seems fine. I've tried playing around with the options but none of them seem to change anything for this line?
|
Removed commit that was applying of rules format source, so it is easier to apply this PR when time comes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This one creates new make target "format" to execute formatting of python code.
Make sure to install yapf package with
pip install yapf