Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace deprecated Request.filter() with Request.post_filter() #109

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

jedihe
Copy link

@jedihe jedihe commented Apr 28, 2017

Very hackish for now, just missing proper upstreaming of the update to elastic.js and doing a proper build of elasticui (both unminified and minified).

@jenswitzel
Copy link

Does it still work this way? We've got serious problems with ES5.x although i included your changes.

@jedihe
Copy link
Author

jedihe commented Mar 27, 2019

@jviele this patch is currently being used in a project that queries an Elasticsearch 5.x instance (5.1.x). Search queries work just fine. Make sure to check the request payload and verify it includes the top-level "post_filter" entry.

@jenswitzel
Copy link

jenswitzel commented Apr 2, 2019

@jedihe thanks a lot. i really appreciate your help. After adding the changes from filter to post_filter it works :-) Had another problem during migration from ES2 to ES5 and access rules. Therefore i'll open another request...

@jenswitzel
Copy link

Sorry to tell you: Its just working with a migrated ES2_to_ES5 index. When i try to catch a new ES5 built index, elasticUI shows nothing but a console error message:

"Quellübergreifende (Cross-Origin) Anfrage blockiert: Die Gleiche-Quelle-Regel verbietet das Lesen der externen Ressource auf https://someserver/someindex/_search?size=10&from=0. (Grund: CORS-Kopfzeile 'Access-Control-Allow-Origin' fehlt)." although we think we added Cross-Origin rules :-(

Why does it work with old ES Version 2 built index? Why not with freshly built ES Version 5? Strange...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants