Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make more properties configurable, add some tests #20

Merged
merged 1 commit into from
Feb 17, 2016

Conversation

domoritz
Copy link
Collaborator

Fixes #13

@domoritz
Copy link
Collaborator Author

CC @mprudhom

@domoritz
Copy link
Collaborator Author

@YousefED If you could add travis, the tests could run automatically.

Also thanks for being so quick with the reviews and merges. That makes it so much easier for us to use this library.

@YousefED
Copy link
Owner

Great stuff! Also thanks for making args a nicely typed object.

My only question before merging; any specific reason you've removed the "dist" outdir and opted for outputting in the root dir?

@domoritz
Copy link
Collaborator Author

My only question before merging; any specific reason you've removed the "dist" outdir and opted for outputting in the root dir?

It made some things much easier. For example if the tests are compiled in the same directory as the ts file, I can refer to the tjs.js file, and the test examples in ts and it compiles to the correct js. I'm not sure how I would have to rewrite the relative import paths.

YousefED added a commit that referenced this pull request Feb 17, 2016
Make more properties configurable, add some tests
@YousefED YousefED merged commit a503fef into YousefED:master Feb 17, 2016
@YousefED
Copy link
Owner

Ok makes sense. Ideally I'd prefer a different output directory, but no priority to sort this out now I think

@domoritz
Copy link
Collaborator Author

Yeah, I'd prefer it as well but the effort to make it work didn't seem worth it at this point.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants