-
Notifications
You must be signed in to change notification settings - Fork 317
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FIX: Issue #511: Does not generate definition for Unions and Intersection Types #512
Conversation
Fix for issue YousefED#511
Could you minimize the changes in this pull request? It's hard to review it otherwise. Thanks! |
There are only 3 lines to be reviewed indeed. // typescript-json-schema.ts line 1231
if(isRawType && reffedType?.escapedName && (typ as any).types) {
isRawType = false;
} The other ones are new tests and fixes in old tests. |
Great. The formatting changes are throwing me off a bit but I can take a look. |
I've just adjusted old files formatting. Now I think it is quite easy to review :) |
Thank you |
@domoritz I have just found a problem. Some types are being generated with |
It's possible to solve with a little change
|
Hi @afonsof, I would propose to have a possibility to opt-out to use this feature. |
Fix for issue #511
Please:
Readme.md