Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: resolve blacklist false-positives for specific function names #16

Merged
merged 1 commit into from
Dec 8, 2022

Conversation

Anve94
Copy link
Member

@Anve94 Anve94 commented Dec 8, 2022

Changed

  • Git blacklist now matches on words instead of characters by default.
  • The git blacklist configuration for rejecting accidentally commited merge conflicts now properly reflects the
    full set of characters used by git.

Fixed

  • Resolved issue where the updated git blacklist configuration would provide a false positive result
    on functions ending with add() or odd() due to checks on dump and die dd() statements.

Added

  • Git blacklist now checks for exit() usage.

@Anve94 Anve94 force-pushed the bugfix/git-blacklist-parsing branch from 95d8f58 to a844a62 Compare December 8, 2022 13:45
@Anve94 Anve94 force-pushed the bugfix/git-blacklist-parsing branch from a844a62 to a4bc1c1 Compare December 8, 2022 13:48
@Anve94 Anve94 requested a review from fredden December 8, 2022 13:49
@Anve94 Anve94 merged commit abc42ee into master Dec 8, 2022
@Anve94 Anve94 deleted the bugfix/git-blacklist-parsing branch December 8, 2022 14:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants