Improve Evaluator/Visualizer library #158
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@tiffanymtang I'm going to remove the upstream dependency on |
* Before: evaluators would compute global and within-group metrics; After: evaluators only compute within group metrics if `group_cols` is specified.
* Fix bug when retrieving cached results when functions are used in `*_params` (e.g., `dgp_params`). * Bug was due to differences in source bytecodes for functions. This caused issues in `dplyr::*_join`. Workaround is to use `duplicated` which ignores these source bytecodes. * Also need to `removeSource()` for functions (`.dgp_fun`, `.method_fun`) that involve global assignment (`<<-`). [See test-checkpointing example]
* Refactor main evaluator and visualizer constructors: `eval_constructor`, `eval_summarizer`, `plot_eval_constructor`, `plot_fit_constructor` * Rename arguments for more uniformity * Streamline evaluator and visualizer library functions using the main constructor functions
* Fix bug if NULL arguments are passed to Visualizer library functions * Don't remove original vary_param columns if 2+ parameters are varied across
|
Yup that sounds good to me. Thanks! |
jpdunc23
approved these changes
May 9, 2023
There was a problem hiding this comment.
@tiffanymtang I took a quick look over it and lgtm to merge into main. Let's let the tests run and then feel free to merge in unless something real fails (i.e., that isn't just the GitHub runner being stubborn).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Streamline main developer functions:
eval_constructor(): Constructs an Evaluator that evaluates some function (e.g., metric) for each row infit_results. Also unnests and groups columns if specified.eval_summarizer(): Takes a grouped data.frame and summarizes output using common summary statistics (i.e., mean, median, min, max, sd, raw) or custom summary functions.plot_eval_constructor(): Constructs a Visualizer that takes in either the data or the name of the Evaluator to plot and creates basic plot summaries (e.g., boxplot, scatter plot, line plot, bar plot, with/without error bars) with convenient defaults for what to plot on the x, y, facets, etc.plot_fit_constructor(): Constructs a Visualizer that makes a plot (given some plotting function) of the fit results from a given replicateOther improvements:
Bug fixes
groupargumentadd_vary_across()due to confusion betweenfandfield_namein.check_each_vary_across()