Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Data Loading Logs #31

Open
fabianbosshard opened this issue Apr 15, 2024 · 2 comments
Open

Data Loading Logs #31

fabianbosshard opened this issue Apr 15, 2024 · 2 comments
Labels
bug Something isn't working

Comments

@fabianbosshard
Copy link

Hello Yuan

Thanks for the great work and for open-sourcing everything!

I have a quesiton about traintest_mask.py: Shouldn't end_time be updated after the evaluation? Because I think the way it is currently implemented leads to a very large number for per_sample_data_time direclty after the evaluation:

image

At first I thought it was because of cache or something similar, but I think it is because the evaluation time is also included in per_sample_data_time in the first iteration after the evaluation.

Best Regards,
Fabian

@YuanGongND YuanGongND added the bug Something isn't working label Apr 15, 2024
@YuanGongND
Copy link
Owner

hi Fabian,

Thanks for pointing out this, it might be a bug, but it does not impact the performance, right? I just use this to check I/O and network bottleneck.

-Yuan

@fabianbosshard
Copy link
Author

Thank you for the quick response. No don't worry, it has no impact on performance, the variable is onnly used to check I/O bottleneck, as you said!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants