Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add options for relaxing origin matching #37

Merged
merged 22 commits into from Oct 9, 2019
Merged

Add options for relaxing origin matching #37

merged 22 commits into from Oct 9, 2019

Conversation

emlun
Copy link
Member

@emlun emlun commented Sep 12, 2019

Fixes #15, fixes #34.

@emlun emlun added the enhancement New feature or request label Sep 12, 2019
@emlun emlun self-assigned this Sep 12, 2019
@coveralls
Copy link

Pull Request Test Coverage Report for Build 295

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 17 unchanged lines in 3 files lost coverage.
  • Overall coverage decreased (-0.2%) to 93.023%
Files with Coverage Reduction New Missed Lines %
/home/travis/build/Yubico/java-webauthn-server/webauthn-server-core/src/main/java/com/yubico/webauthn/FinishAssertionSteps.java 2 97.33%
/home/travis/build/Yubico/java-webauthn-server/webauthn-server-core/src/main/java/com/yubico/webauthn/FinishRegistrationSteps.java 7 91.57%
/home/travis/build/Yubico/java-webauthn-server/webauthn-server-core/src/main/java/com/yubico/webauthn/RelyingParty.java 8 74.19%
Totals Coverage Status
Change from base Build 292: -0.2%
Covered Lines: 640
Relevant Lines: 688
💛 - Coveralls

@emlun emlun requested a review from aveenismail October 1, 2019 14:10
@emlun emlun requested a review from aveenismail October 2, 2019 13:09
@emlun emlun merged commit 33113ca into master Oct 9, 2019
@emlun emlun deleted the origin-matching branch October 9, 2019 11:00
This was referenced Oct 9, 2019
Closed
Closed
@emlun emlun added this to the 1.5.0 milestone Oct 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aveenismail aveenismail Awaiting requested review from aveenismail

Assignees

@emlun emlun

Labels
enhancement New feature or request
Milestone
1.5.0
Development

Successfully merging this pull request may close these issues.

Problems with origin matching. Poll: Add support for wildcard subdomain matching?
3 participants
@emlun @coveralls @aveenismail