Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Miscellaneous portability fixes #142

Merged
merged 7 commits into from Mar 5, 2020
Merged

Miscellaneous portability fixes #142

merged 7 commits into from Mar 5, 2020

Conversation

zoulasc
Copy link
Contributor

@zoulasc zoulasc commented Mar 3, 2020

No description provided.

@zoulasc
Avoid const cast-away
870fe34
@zoulasc
- cast -1 to the appropriate types
eb707e1 
- split lines
@zoulasc
- move PAM_MODUTIL_DEF_PRIVS below parse_cfg, so that cfg->debug_file
45e79d6 
  gets initialized first (this is c99, statement before decl).
- introduce free_const() macro to avoid const cast-away warnings.
- Add PAM_MODULE_ENTRY() macro used by OpenPAM.
@zoulasc
Provide an empty statement for non-debugging code.
3fea138
@zoulasc
- explicitly check against NULL to avoid some compiler warnings
1c5a805 
- fix const cast-away.
- Since we include <syslog.h> unconditionally allow syslog use on other
  unixes, not just linux. We check that we provide a LOG_DEBUG macro instead.
@a-dma
Copy link
Member

a-dma commented Mar 4, 2020

Thanks, it looks like this is not passing CI.

@a-dma
Copy link
Member

a-dma commented Mar 5, 2020

Thank you, merging.

@a-dma a-dma merged commit 89412d9 into Yubico:master Mar 5, 2020
@zoulasc
Copy link
Contributor Author

zoulasc commented Mar 5, 2020

Thanks for the quick merge!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@zoulasc @a-dma