add nullok support to challenge-response mode #121
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
klali
requested changes
Apr 10, 2017
util.c
Outdated
| * | ||
| * Returns one of AUTH_FOUND, AUTH_NOT_FOUND, AUTH_ERROR | ||
| */ | ||
| int len; |
There was a problem hiding this comment.
len should probably be a size_t since it's assigned result of strlen(), passed to malloc() and passed to snprintf()
| @@ -282,6 +283,64 @@ int challenge_response(YK_KEY *yk, int slot, | |||
| } | |||
|
|
|||
| int | |||
| check_user_challenge_file(const char *chalresp_path, const struct passwd *user, FILE *debug_file) | |||
There was a problem hiding this comment.
debug_file isn't used in the function, consider dropping it?
There was a problem hiding this comment.
I've added some error messages instead
|
|
||
| r = glob(userfile_pattern, 0, NULL, &userfile_glob); | ||
| globfree(&userfile_glob); | ||
| switch (r) { |
There was a problem hiding this comment.
I'd prefer for all cases in the switch to look the same, setting ret+break, this decreases risks of messing this up in the future.
There was a problem hiding this comment.
Comment shoud explain my idea. I would keep it that way (moved break to the top and then ret+goto out)
|
In a free moment I will fix this, but for now I didn't have any. |
klali
approved these changes
Jun 26, 2017
|
Ok. Merging this, thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, I wanted to use nullok flag with challenge-response mode so I added the support. I hope it will be helpful.
It solves issue "Cannot login with nullok using challenge-response? #119"