Several hardenings and buffer handling improvements for ykpamcfg #160
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of hardcoding the buffer size to 256, using PATH_MAX makes more sense here, since this can be defined differently on different platforms. This is not perfect, though, refer to [1] for some details. In our case it should be good enough. [1]: https://eklitzke.org/path-max-is-tricky
This checks the return code of snprintf() and makes sure that fullpath actually fits into a buffer of size PATH_MAX. Otherwise, it will output an error and exit.
strncpy() is _NOT_ a safe version of strcpy() and it should not be used (ineffective and dangerous since a NUL termination might be missing). Instead snprintf() the way to safely construct a string with a given limit. This commit implements this for the action parsing in ykpamcfg.
Not an issue, just the former is considered good practice.
This limits the allowable action length when arguments are parsed to ACTION_MAX_LEN, since this might be exploited otherwise.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This series contains a couple of commits dealing with potential issues with buffer handling. Nothing too severe, but nevertheless best practices should be used.