Support PKCS11 3.0 #183
Draft
Support PKCS11 3.0 #183
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qpernil
force-pushed
the
pkcs11-3_0
branch
2 times, most recently
from
d1227c1
to
432dddc
Compare
qpernil
force-pushed
the
pkcs11-3_0
branch
3 times, most recently
from
b749973
to
78b71b8
Compare
qpernil
force-pushed
the
pkcs11-3_0
branch
2 times, most recently
from
11c58d9
to
913b3d9
Compare
|
Adresses #270 |
qpernil
force-pushed
the
pkcs11-3_0
branch
6 times, most recently
from
6f7b239
to
2b25889
Compare
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Comment on lines
+3864
to
+3878
| switch (m) { | ||
| case CKM_EDDSA: | ||
| return true; | ||
|
|
||
| default: | ||
| break; | ||
| } |
Check notice
Code scanning / CodeQL
No trivial switch statements Note
| @@ -4946,6 +5159,214 @@ | |||
| return CKR_OK; | |||
| } | |||
|
|
|||
| CK_RV parse_ed_generate_template(CK_ATTRIBUTE_PTR pPublicKeyTemplate, | |||
Check warning
Code scanning / CodeQL
Poorly documented large function Warning
| @@ -1698,7 +1786,7 @@ | |||
| return CKR_OK; | |||
| } | |||
|
|
|||
| static CK_RV load_public_key(yh_session *session, uint16_t id, EVP_PKEY *key) { | |||
| static CK_RV load_public_key(yh_session *session, uint16_t id, EVP_PKEY **key) { | |||
Check warning
Code scanning / CodeQL
Poorly documented large function Warning
| } | ||
| char config[256]; | ||
| assert(strlen(connector_url) + strlen("connector=") < 256); | ||
| sprintf(config, "connector=%s", connector_url); |
Check failure
Code scanning / CodeQL
Unbounded write Critical
Having problems signing with EdDSA on YubiHSM2 via PKCS11. Getting an pkcs11:p11prov_Sign:The size of plaintext input data to a cryptographic operation is invalid (Out of range):interface.gen.c:679:Error returned by C_Sign error As I understand the PKCS11 v3.0 spec, the 1024 bit limit (note by "adma" in line 2228) applies only to "ECDSA without hashing" (CKM_ECDSA) as it only processes a hash value. see: https://docs.oasis-open.org/pkcs11/pkcs11-curr/v3.0/os/pkcs11-curr-v3.0-os.html#_Toc30061189 EdDSA does not have this limit, so the size of "op_info->buffer" should be the limiting factor see: https://docs.oasis-open.org/pkcs11/pkcs11-curr/v3.0/os/pkcs11-curr-v3.0-os.html#_Toc30061191
…ation on MacOS runners
…ild: Fix Redhat and MacOS builds
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PKCS11 3.0 support, and also added ed25519 support, mechanisms for which were added in pkcs11 3.0