Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add PivManagementKeyPopup #81

Merged
merged 4 commits into from Nov 15, 2018
Merged

Add PivManagementKeyPopup #81

merged 4 commits into from Nov 15, 2018

Conversation

emlun
Copy link
Member

@emlun emlun commented Nov 14, 2018

Example usage:

views.pivGetManagementKeyAndThen(
    function(pin) {
        console.log("pin", pin)
    },
    function(key) {
        console.log("key", key)
    }
);

@emlun emlun self-assigned this Nov 14, 2018
@emlun emlun requested a review from dagheyman November 14, 2018 15:48
dagheyman
dagheyman suggested changes Nov 15, 2018
View reviewed changes
Copy link

@dagheyman dagheyman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool! It feels a bit strange to require two callbacks, but I don't have a better solution in mind currently.

ykman-gui/qml/ContentStack.qml Outdated Show resolved Hide resolved
ykman-gui/qml/PivManagementKeyPopup.qml Outdated Show resolved Hide resolved
@emlun emlun merged commit 4ca1585 into piv Nov 15, 2018
@emlun emlun deleted the piv-mgm-key-popup branch November 15, 2018 11:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dagheyman dagheyman dagheyman requested changes

Assignees

@emlun emlun

Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@emlun @dagheyman