Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merge SW enums #172

Merged
merged 2 commits into from Nov 8, 2018
Merged

Merge SW enums #172

merged 2 commits into from Nov 8, 2018

Conversation

emlun
Copy link
Member

@emlun emlun commented Nov 7, 2018

This would merge into #169.

@emlun emlun requested a review from dagheyman November 7, 2018 15:17
@emlun emlun self-assigned this Nov 7, 2018
@emlun
Copy link
Member Author

emlun commented Nov 7, 2018

Right now this leaves piv.SW as a standalone enum with some overlap with driver_ccid; perhaps we want to merge that into driver_ccid.SW as well.

@dagheyman
Copy link
Contributor

Yeah, maybe we can get away with a single SW enum in driver_ccid.py.

@emlun emlun merged commit 9cdd142 into piv-errors Nov 8, 2018
@emlun emlun deleted the merge-sw-enums branch November 8, 2018 12:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dagheyman dagheyman dagheyman approved these changes

@dainnilsson dainnilsson Awaiting requested review from dainnilsson

Assignees

@emlun emlun

Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@emlun @dagheyman