New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix bug #140 Missing return after completion in PIV signWithKeyInSlot #141

Merged

jensutbult merged 1 commit into Yubico:main from samngms:bugfix/piv-signWithKeyInSlot-double-callback-invocation

Mar 22, 2024

Contributor

samngms commented Dec 11, 2023

Three is a missing return after calling completion, just one line of code.

Without the return, the code will continue to run after the 1st completion() and then when it calls the 2nd completion(), it will throw

Illegal callback invocation from native module. This callback type only permits a single invocation from native code.


          Update YKFPIVSession.m

edf5779

return after calling completion

samngms mentioned this pull request

Missing return after completion in PIV signWithKeyInSlot #140

Open

jensutbult merged commit 24b954a into Yubico:main

Contributor

jensutbult commented Mar 22, 2024

Thank you for the bug fix!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment