Device capabilities blocklist #152
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It is unlikely Apple will be introducing any more Lightning devices. As such, for +supportsSmartCardOverUSBC, we can use the list of all released Lightning devices, assuming that any device that doesn't use Lightning uses USB-C. This will prevent having to release app updates every time Apple releases a new device.
All iPhones since iPhone 7 have supported NFC. Switch to checking that the current device is an iPhone and is not earlier than the iPhone 7 for +deviceIsNFCEnabled. This way, we won't have to issue updates when new iPhones are released by Apple.
MichaelBuckley
force-pushed
the
device-capabilities-blocklist
branch
from
0151e06
to
5e03cbc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
Apple introduced new iPad models a couple days ago, all of which use USB-C. However, because Yuibikit uses a list of known models to check support for USB-C, apps using Yubikit will need to update to work on these devices.
Becuase the EU is requiring that all smartphones use USB-C by the fall of this year, and since that is when Apple releases new iPhones, it is unlikely that Apple will ever release another Lightning iDevice again.
This pull request contains a change to switch
+supportsSmartCardOverUSBCto use a list of devices which don't support USB-C. If you accept this pull request, going forward, apps will not have to update when new devices come out in order to support USB-C on these devices.It also contains a similar change to
+ deviceIsNFCEnabledfor the same reason. It assumes that all future iPhones will have NFC capability, and that other iDevices will not.Thank you for your consideration.