Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ability to don't use compaction thread pool for flushes #1874

Closed
spolitov opened this issue Jul 23, 2019 · 0 comments
Closed

Add ability to don't use compaction thread pool for flushes #1874

spolitov opened this issue Jul 23, 2019 · 0 comments
Assignees
@spolitov
Labels
area/docdb YugabyteDB core features

Comments

@spolitov
Copy link
Contributor

No description provided.

@spolitov spolitov added the area/docdb YugabyteDB core features label Jul 23, 2019
@spolitov spolitov self-assigned this Jul 23, 2019
spolitov added a commit that referenced this issue Jul 23, 2019
@spolitov
[#1874]: Add ability to avoid using the compaction thread pool for fl…
ed54862 
…ushes

Summary:
Added the following flags:
- use_compaction_thread_pool_for_flushes: Whether we should use the compaction thread pool for flushes, false by default
- use_compaction_thread_pool_for_compactions: Whether we should use compaction thread pool for compactions, true by default
When both flags set to the false the original behavior (pre D6778) will be restored.

- compaction_thread_pool_size: Max running workers in compaction thread pool. -1 for auto detection. -1 by default.

Test Plan: Jenkins

Reviewers: amitanand

Reviewed By: amitanand

Subscribers: mikhail, ybase

Differential Revision: https://phabricator.dev.yugabyte.com/D6939
spolitov added a commit that referenced this issue Aug 3, 2019
@spolitov
[#1874]: Rename flags related to thread pool used by compactions and …
c02a546 
…flushes

Summary:
New flag names with descriptions:
- use_priority_thread_pool_for_flushes. Default false.
    When true priority thread pool will be used for flushes, otherwise
    Env thread pool with Priority::HIGH will be used.

- use_priority_thread_pool_for_compactions. Default true.
    When true priority thread pool will be used for compactions, otherwise
    Env thread pool with Priority::LOW will be used.

- priority_thread_pool_for_compactions_and_flushes_size. Default -1.
    Max running workers in compaction thread pool.
    If -1 and max_background_compactions is specified - use max_background_compactions.
    If -1 and max_background_compactions is not specified - use sqrt(num_cpus).

Test Plan: Jenkins

Reviewers: kannan

Reviewed By: kannan

Subscribers: ybase

Differential Revision: https://phabricator.dev.yugabyte.com/D6950
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@spolitov spolitov

Labels
area/docdb YugabyteDB core features
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@spolitov