Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[dist-txns] Intents could be present w/o transaction metadata #591

Closed
spolitov opened this issue Nov 15, 2018 · 1 comment
Closed

[dist-txns] Intents could be present w/o transaction metadata #591

spolitov opened this issue Nov 15, 2018 · 1 comment
Assignees
@spolitov
Labels
kind/bug This issue is a bug

Comments

@spolitov
Copy link
Contributor

When adding intents batch we don't hold RequestScope object, that could cause situation when transaction metadata is deleted, but intents for this transaction still exists.
@spolitov spolitov self-assigned this Nov 15, 2018
@spolitov spolitov added the kind/bug This issue is a bug label Nov 15, 2018
yugabyte-ci pushed a commit that referenced this issue Nov 15, 2018
@spolitov
#591: Extended lifetime of RequestScope while writing provisional rec…
620c23c 
…ords

Summary:
RequestScope is an utility class that allows us to prevent deletion of transaction metadata while it is still being used by a request. When adding a batch of provisional records, we currently don't hold a RequestScope object. This could cause a situation when transaction metadata is deleted, but provisional records for this transaction remain.

In this diff we are extending the lifetime of the RequestScope to fix this issue.

Also added handling of this case while getting transaction status for existing provisional records.

Test Plan: Jenkins

Reviewers: timur, robert, mikhail

Reviewed By: mikhail

Subscribers: ybase

Differential Revision: https://phabricator.dev.yugabyte.com/D5729
@kmuthukk kmuthukk changed the title Intents could be present w/o transaction metadata [dist-txns] Intents could be present w/o transaction metadata Nov 15, 2018
@kmuthukk
Copy link
Collaborator

Fixed in 620c23c.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@spolitov spolitov

Labels
kind/bug This issue is a bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@spolitov @kmuthukk