Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enhance mem trackers view #605

Closed
spolitov opened this issue Nov 26, 2018 · 0 comments
Closed

Enhance mem trackers view #605

spolitov opened this issue Nov 26, 2018 · 0 comments
Assignees
@spolitov
Labels
kind/enhancement This is an enhancement of an existing feature

Comments

@spolitov
Copy link
Contributor

Use tree to display mem trackers to reflect original structure.
@spolitov spolitov added the kind/enhancement This is an enhancement of an existing feature label Nov 26, 2018
@spolitov spolitov self-assigned this Nov 26, 2018
yugabyte-ci pushed a commit that referenced this issue Nov 26, 2018
@spolitov
#605: Change the /mem-trackers internal UI page to a tree-like view
4e79caf 
Summary:
Mem trackers are organized in a tree, so it should be reflected in the /mem-trackers view.
Currently to show mem trackers we enumerate them using BFS and show only tracker parent.
Since we have parents with the same names in different hierarchies, it is quite hard to
understand where this tracker actually resides.

To address this issue this diff changes the way of how mem trackers are enumerated and shows them
in a table using varying levels of padding, so it looks like an actual tree of mem trackers.

Other enhancement:
1) Removed the parent column, since it is superfluous now.
2) Moved the limit column to the end of columns, because otherwise it is easy to confuse it for the current consumption.
3) Added spacing to end of the page, so the footer does not hide the last line of the mem trackers table.

Test Plan: Tested manually.

Reviewers: karthik, bogdan, kannan, mikhail

Reviewed By: mikhail

Subscribers: mikhail, ybase

Differential Revision: https://phabricator.dev.yugabyte.com/D5753
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@spolitov spolitov

Labels
kind/enhancement This is an enhancement of an existing feature
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@spolitov