Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[YSQL] psql client termination is not handled correctly #976

Closed
fizaaluthra opened this issue Mar 12, 2019 · 0 comments
Closed

[YSQL] psql client termination is not handled correctly #976

fizaaluthra opened this issue Mar 12, 2019 · 0 comments
Assignees
@fizaaluthra
Labels
kind/bug This issue is a bug

Comments

@fizaaluthra
Copy link
Member

fizaaluthra commented Mar 12, 2019 •
edited
Loading

If we start max_connections psql clients (and then exit any one of them), the next client connection fails with psql: FATAL: sorry, too many clients already

To reproduce the error easily, reduce the max_connections field in postgresql.conf. The default is 100.
@fizaaluthra fizaaluthra self-assigned this Mar 14, 2019
@fizaaluthra fizaaluthra changed the title psql client termination is not handled correctly [YSQL] psql client termination is not handled correctly Mar 14, 2019
yugabyte-ci pushed a commit that referenced this issue Mar 15, 2019
@fizaaluthra
[YSQL] ENG-4839 (#976): Handle postgres session termination correctly…
7ea3cd0 
… in YB mode

Summary: ProcArrayAdd() is executed for MyProc, so we should also execute ProcArrayRemove() for MyProc

Test Plan: Try starting more than max_connection sessions.

Reviewers: mikhail, mihnea, neha

Reviewed By: neha

Subscribers: neha, kannan, hector, yql

Differential Revision: https://phabricator.dev.yugabyte.com/D6321
@kmuthukk kmuthukk added the kind/bug This issue is a bug label Mar 16, 2019
@mbautin mbautin mentioned this issue Mar 21, 2019
Closed
@def- def- mentioned this issue Aug 8, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@fizaaluthra fizaaluthra

Labels
kind/bug This issue is a bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@kmuthukk @fizaaluthra