Modify info #14
Merged
Modify info #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. Modify Mocha using method. 2. Try to write a factory to getTreeItem(). 3. Add a search by push feature. 4. Create a member: sn for Article, so that can sort the articles' order.
Yukaii
reviewed
Jul 13, 2019
Yukaii
reviewed
Jul 13, 2019
|
感謝 @JosephT5566 🍻 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi~
最近試著再go through這個專案，稍微修改了一些東西
再麻煩你有空的時候幫忙review一下~ 看哪邊是否真的有需要或是其他建議 > <
Changes
使用
npm run test可直接執行，但是還沒認真思考要怎麼拆分進行unit test的部分。但是 ptt-client 沒有這個介面，算是我自己測試的功能。本來想說用處理傳回來的資料來實現，但是如果未來要繼續實現搜尋作者、搜尋文章還是得要回頭去維護 ptt-client 的介面~
另外我希望文章標題也能顯示出推文以便了解鄉民的傾向，所以也把這個開啟了。