Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Might I send a pull request to support Redmine 3.x? #18

Open
akiko-pusu opened this issue Aug 26, 2018 · 4 comments
Open

Might I send a pull request to support Redmine 3.x? #18

akiko-pusu opened this issue Aug 26, 2018 · 4 comments

Comments

@akiko-pusu
Copy link
Contributor

Hello, @YukiKita san.
Thank you for your funny plugin. I used to install and use this plugin when I started to administrate Redmine (since version 1.x).
Though now I don’t use Redmine itself, I personally think this plugin is pretty good for Redmine beginners.

So I just modified some codes to support current stable Redmine v3.x on my forked repository.

Might I send a pull request to support Redmine 3.x?
Of course, you can reject or review above request.

リポジトリは最初に作っていただいたYukiさんのところが良いと考えていますので、もしよかったらご検討ください。拙い修正ではありますので、もちろんrejectしたり、ベースにして調整くださっても構いません。

もしOKな場合でも、master以外に適切なブランチがあれば、教えていただけると幸いです。

@YukiKita
Copy link
Owner

@akiko-pusu さん
Redmine 3.xに対応していただき、ありがとうございます。
私のリポジトリのmasterブランチに対してプルリクエストを作成いただければ、マージさせていただきたいと思います。
よろしくお願いします。

@akiko-pusu
Copy link
Contributor Author

ありがとうございます!
マージされると、逆にRedmine3以外は切り捨てられてしまいますので、タグ付けかバージョンを調整いただけると幸いです。
いまのところは、1.1.3-dev で設定しています。

@akiko-pusu
Copy link
Contributor Author

Thank you so much for merging my PR.
It seems some style adjustments are required, so I will make a pull request again.

@akiko-pusu
Copy link
Contributor Author

akiko-pusu#1 was removed because I've removed and re-create forked repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants