Pull request to support Redmine 3.x #19
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The problem has been resolved in #11176. http://www.redmine.org/issues/11776
Refactor to apply selectable role id as filtere parameter in case changing date range.
Change redirect url from index to show in case edit / delete comment. Update test code.
(Tooltip feature is now implemented via CSS)
Format code style.
Test pull request to master branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#18 でご相談した件、プルリクを出させていただきます。
変更箇所についてですが、一度他の方が対応してくださったRedmine2.x対応のものをもとにしていますので、私以外のコミットのほうが多く入っています。
(@luckval さん, @naitoh さんが対応したくださった分）
わたしの追加は
19a646f...083939b になります。
パブリックメソッドに対するテストは基本的にそのまま保持して、若干フォーマットや引数の渡し方が変わった分を修正しています。
お手数おかけしますが、もしお時間のあるときにでも見ていただけると幸いです。
また、この件に関しての不具合がありましたら、引き続きウォッチいたしますので、どうぞよろしくお願いいたします。