[HTTP] Clean up unused generic (elastic#156810)

## Summary This PR removes an unused generic `R` from versioned route definitions.
YulNaumenko · May 7, 2023 · 1abd32c · 1abd32c
1 parent f207cb5
commit 1abd32c
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 8 deletions.
diff --git a/...s/core/http/core-http-router-server-internal/src/versioned_router/core_versioned_route.ts b/...s/core/http/core-http-router-server-internal/src/versioned_router/core_versioned_route.ts
@@ -28,7 +28,7 @@ import { injectResponseHeaders } from './inject_response_headers';
 
 import { resolvers } from './handler_resolvers';
 
-type Options = AddVersionOpts<unknown, unknown, unknown, unknown>;
+type Options = AddVersionOpts<unknown, unknown, unknown>;
 
 // This validation is a pass-through so that we can apply our version-specific validation later
 export const passThroughValidation = {

diff --git a/packages/core/http/core-http-router-server-internal/src/versioned_router/types.ts b/packages/core/http/core-http-router-server-internal/src/versioned_router/types.ts
@@ -26,7 +26,7 @@ export interface VersionedRouterRoute {
   /** @experimental */
   handlers: Array<{
     fn: RequestHandler;
-    options: AddVersionOpts<unknown, unknown, unknown, unknown>;
+    options: AddVersionOpts<unknown, unknown, unknown>;
   }>;
 }
 

diff --git a/packages/core/http/core-http-server/src/versioning/types.ts b/packages/core/http/core-http-server/src/versioning/types.ts
@@ -185,7 +185,7 @@ interface FullValidationConfig<P, Q, B> {
  * of an endpoint etc.
  * @experimental
  */
-export interface AddVersionOpts<P, Q, B, R> {
+export interface AddVersionOpts<P, Q, B> {
   /**
    * Version to assign to this route
    * @experimental
@@ -213,10 +213,8 @@ export interface VersionedRoute<
    * @returns A versioned route, allows for fluent chaining of version declarations
    * @experimental
    */
-  addVersion<P = unknown, Q = unknown, B = unknown, R = any>(
-    options: AddVersionOpts<P, Q, B, R>,
-    handler: (
-      ...params: Parameters<RequestHandler<P, Q, B, Ctx>>
-    ) => MaybePromise<IKibanaResponse<R>>
+  addVersion<P = unknown, Q = unknown, B = unknown>(
+    options: AddVersionOpts<P, Q, B>,
+    handler: (...params: Parameters<RequestHandler<P, Q, B, Ctx>>) => MaybePromise<IKibanaResponse>
   ): VersionedRoute<Method, Ctx>;
 }