Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use globs to match controllers and allow directory-based controllers #8

Merged
merged 3 commits into from
Mar 3, 2024

Conversation

YummYume
Copy link
Owner

@YummYume YummYume commented Mar 3, 2024

Description

This PR adds a whole new way to match controllers using the Bun glob API.

It also allows directory-based controllers (they can even be matched with file-based controllers !).

Duplicate controller definitions can also be handled by the user.

Closes #7.

Type of change

Please add any relevant information to the type of change you've made.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update (or is a documentation update)
  • HIGH IMPORTANCE (requires a fast merging)

Has This Been Tested?

Please describe the tests that you ran to verify your changes. It is way more likely for a PR to be merged and approved with successful tests.

  • Yes, I ran tests
  • No, I did not include any test
  • No test is needed for this change

@YummYume YummYume force-pushed the feature/directory-controllers branch from 417734b to 31e827a Compare March 3, 2024 20:32
@YummYume YummYume self-assigned this Mar 3, 2024
@YummYume YummYume merged commit 727b084 into master Mar 3, 2024
4 checks passed
@YummYume YummYume deleted the feature/directory-controllers branch March 3, 2024 20:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEATURE] Ability to register stimulus controllers using containing folder as identifier
1 participant