fix: dynamic import waline css, close #42

YunYouJun · Jul 10, 2022 · 8d693d0 · 8d693d0 · github-actions · Jul 10, 2022
1 parent b7502a7
commit 8d693d0
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 3 deletions.
diff --git a/packages/valaxy/client/composables/comments/waline.ts b/packages/valaxy/client/composables/comments/waline.ts
@@ -4,8 +4,6 @@ import { useI18n } from 'vue-i18n'
 import { useRoute } from 'vue-router'
 
 import type { WalineInitOptions, WalineInstance } from '@waline/client'
-
-import '@waline/client/dist/waline.css'
 import { cdnPrefix } from '../../utils'
 
 /**
@@ -20,6 +18,9 @@ export function useWaline(options: {} = {}, cdn = cdnPrefix) {
   if (!isClient)
     return
 
+  // import css
+  import('@waline/client/dist/waline.css')
+
   const route = useRoute()
 
   const { locale } = useI18n()

diff --git a/packages/valaxy/client/config.ts b/packages/valaxy/client/config.ts
@@ -5,7 +5,10 @@ import valaxyContext from '/@valaxyjs/context'
 import type { ComputedRef, InjectionKey, Ref } from 'vue'
 import { computed, inject, readonly, shallowRef } from 'vue'
 // import type { RouteMeta } from 'vue-router'
-import type { PageData, ValaxyConfig } from '../types'
+// fix build caused by pnpm
+// This is likely not portable. A type annotation is necessary.
+// https://github.com/microsoft/TypeScript/issues/42873
+import type { PageData, ValaxyConfig } from 'valaxy/types'
 
 /**
  * parse valaxy config