fix: lyricHidden setting does not take effect

YunYouJun · Mar 15, 2024 · f5c2b57 · f5c2b57
1 parent 72be20b
commit f5c2b57
Show file tree

Hide file tree

Showing 3 changed files with 20 additions and 23 deletions.
diff --git a/packages/valaxy-addon-meting/README.md b/packages/valaxy-addon-meting/README.md
@@ -37,11 +37,12 @@ export interface MetingOptions {
   }
 }
 ```
+
 | Configuration Item                    | Description                                                                                        | Default Value |
 | ------------------------------------- | -------------------------------------------------------------------------------------------------- | ------------- |
-| **lyricsLoadOnStart** (optional)      | Specifies whether to hide the lyrics upon startup                                                | `false`       |
-| **aplayerAutoHide** (optional)        | Enables auto-hiding of the APlayer interface when not interacted with. Recommended for use with `aplayerVisibleAfterLoad`                            | `false`        |
-| **aplayerVisibleAfterLoad** (optional) | Determines whether the APlayer interface should be visible immediately after loading is complete | `false`        |
+| **animationIn** (optional)      | Specifies whether to hide the lyrics upon startup                                                | `false`       |
+| **autoHidden** (optional)        | Enables auto-hiding of the APlayer interface when not interacted with. Recommended for use with `aplayerVisibleAfterLoad`                            | `false`        |
+| **lyricHidden** (optional) | Determines whether the APlayer interface should be visible immediately after loading is complete | `false`        |
 
 ## props
 

diff --git a/packages/valaxy-addon-meting/client/observer.ts b/packages/valaxy-addon-meting/client/observer.ts
@@ -3,32 +3,28 @@ import type { MetingOptions } from '../node/index'
 import { onMetingLoad, onMetingLoadBefore } from './hook'
 
 export function setupHiddenLyricHidingObserver() {
-  let observer: MutationObserver | null
-
-  onMounted(() => {
-    observer = new MutationObserver((mutations) => {
-      const lrcElement = document.querySelector('.aplayer-lrc .aplayer-lrc-contents .aplayer-lrc-current') as HTMLElement
-      const lrcButton = document.querySelector('.aplayer-icon-lrc') as HTMLElement
-      function removelrc() {
-        if (lrcElement) {
-          lrcElement.style.display = 'none'
-          if (lrcElement.textContent !== 'Loading') {
-            lrcButton.click()
-            lrcElement.style.display = ''
-            observer?.disconnect()
-          }
+  // This condition needs to be executed before onMounted
+  const observer = new MutationObserver((mutations) => {
+    const lrcElement = document.querySelector('.aplayer-lrc .aplayer-lrc-contents .aplayer-lrc-current') as HTMLElement
+    const lrcButton = document.querySelector('.aplayer-icon-lrc') as HTMLElement
+    function removelrc() {
+      if (lrcElement) {
+        lrcElement.style.display = 'none'
+        if (lrcElement.textContent !== 'Loading') {
+          lrcButton.click()
+          lrcElement.style.display = ''
+          observer?.disconnect()
         }
       }
-      mutations.forEach((_mutation) => {
-        removelrc()
-      })
+    }
+    mutations.forEach((_mutation) => {
+      removelrc()
     })
-    observer.observe(document.body, { childList: true, subtree: true })
   })
+  observer.observe(document.body, { childList: true, subtree: true })
 
   onUnmounted(() => {
     observer?.disconnect()
-    observer = null
   })
 }
 

diff --git a/packages/valaxy-addon-meting/package.json b/packages/valaxy-addon-meting/package.json
@@ -1,7 +1,7 @@
 {
   "name": "valaxy-addon-meting",
   "global": true,
-  "version": "0.1.0",
+  "version": "0.1.1",
   "license": "MIT",
   "repository": {
     "url": "https://github.com/YunYouJun/valaxy/tree/main/packages/valaxy-addon-meting",