Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: integrate bilibili-bangumi-component #346

Closed
wants to merge 2 commits into from

Conversation

yixiaojiu
Copy link
Collaborator

Problem

bilibili-bangumi is a custom component, and Vue will display a warning. However, I am unsure about how to modify this configuration in the plugin hook.

isCustomElement: (tag) => {
return customElements.has(tag)
},

Copy link

vercel bot commented Feb 8, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
valaxy-docs-dev ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 8, 2024 3:18am

Copy link

gitguardian bot commented Feb 8, 2024

⚠️ GitGuardian has uncovered 1 secret following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secret in your pull request
GitGuardian id GitGuardian status Secret Commit Filename
- Generic High Entropy Secret f4e6321 demo/yun/valaxy.config.ts View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secret safely. Learn here the best practices.
  3. Revoke and rotate this secret.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

Our GitHub checks need improvements? Share your feedbacks!

@YunYouJun
Copy link
Owner

Why close it?

@yixiaojiu
Copy link
Collaborator Author

image

There is an error when building for SSG. The ESM module is being mistakenly identified as CJS. This is the repo and branch:
https://github.com/yixiaojiu/valaxy/tree/bangumi

@YunYouJun
Copy link
Owner

Maybe you can pack them to be mjs/cjs.

@yixiaojiu
Copy link
Collaborator Author

Not working 😭. I have trying many methods.

@YunYouJun
Copy link
Owner

YunYouJun commented Feb 12, 2024

Wrap it with <ClientOnly />.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants