Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add vue-router:extendRoute hook #387

Merged
merged 2 commits into from
Apr 29, 2024
Merged

Conversation

KazariEX
Copy link
Contributor

Description

传递 valaxyApp 以提供更丰富的上下文,当前的逻辑不利于在深层触发钩子

Linked Issues

Copilot Descriptions

copilot:all

Copy link

vercel bot commented Apr 27, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
valaxy-docs-dev ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 27, 2024 6:07am

@YunYouJun
Copy link
Owner

YunYouJun commented Apr 29, 2024

如果希望使用 extendRoute 可以配置 valaxyConfig.router?.extendRoute 对应函数。

hook vue-router:extendRoute 对于编写插件时可能会有帮助。

@YunYouJun YunYouJun merged commit 63da97b into YunYouJun:main Apr 29, 2024
10 checks passed
Copy link

Yun Good!

@KazariEX KazariEX deleted the more-hooks branch April 29, 2024 04:33
@KazariEX
Copy link
Contributor Author

我对 ValaxyExtendConfig.extendMd 的作用有些疑惑,它似乎和其他配置一样是覆盖式的,这意味着如果上游主题使用它实现了一些功能,插件或用户对其的再自定义将破坏这些功能的效果。是否应该和 hook 对齐?

@YunYouJun
Copy link
Owner

// TODO: extract to hook call

extendMd API 添加于 hook 功能添加之前,后续将考虑迁移至 hook 实现。

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants