Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add "requests" dependency #6

Merged
merged 6 commits into from
Jan 28, 2023
Merged

add "requests" dependency #6

merged 6 commits into from
Jan 28, 2023

Conversation

lapineige
Copy link
Member

requests python module is missing.

@lapineige lapineige added the enhancement New feature or request label Jan 28, 2023
@lapineige
Copy link
Member Author

!testme

@lapineige lapineige mentioned this pull request Jan 28, 2023
Open
@lapineige
Copy link
Member Author

https://ci-apps-dev.yunohost.org/ci/job/5364

@lapineige
Copy link
Member Author

import requests fails, while now the package installs python3-request.
Should it be installed in the python venv ? 🤔

@lapineige
Copy link
Member Author

If I install it manually using the venv pip3, service starts with no reported error.
Yet #2 still happens.

@lapineige lapineige merged commit 4c127b5 into master Jan 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@lapineige @yunohost-bot