Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Testing #69

Open
wants to merge 32 commits into
base: master
Choose a base branch
from
Open

Testing #69

wants to merge 32 commits into from

Conversation

ericgaspar
Copy link
Member

Problem

  • Description of why you made this PR

Solution

  • And how do you fix that problem

PR Status

  • Code finished and ready to be reviewed/tested
  • The fix/enhancement were manually tested (if applicable)

Automatic tests

Automatic tests can be triggered on https://ci-apps-dev.yunohost.org/ after creating the PR, by commenting "!testme", "!gogogadgetoci" or "By the power of systemd, I invoke The Great App CI to test this Pull Request!". (N.B. : for this to work you need to be a member of the Yunohost-Apps organization)

@marclaporte
Copy link
Contributor

I am a little nervous about stability of Cypht 2.0.1 vs 1.4.x but we will quickly fix any regressions:
#63

@YunoHost-Apps YunoHost-Apps deleted a comment from yunohost-bot May 22, 2024
@ericgaspar
Copy link
Member Author

!testme

@yunohost-bot
Copy link
Contributor

✌️
Test Badge

@yunohost-bot
Copy link
Contributor

📖
Test Badge

@YunoHost-Apps YunoHost-Apps deleted a comment from yunohost-bot May 22, 2024
@ericgaspar
Copy link
Member Author

Time zone and language variables defined in the .env file are not set by default by the application 🤔

@marclaporte
Copy link
Contributor

Time zone and language variables defined in the .env file are not set by default by the application

@Shadow243: Thank you for contributing this: cypht-org/cypht#823

Any wisdom here?

Thanks!

@ericgaspar
Copy link
Member Author

!testme

@yunohost-bot
Copy link
Contributor

📚 🪱
Test Badge

@yunohost-bot
Copy link
Contributor

Fingers crossed!
Test Badge

@Shadow243
Copy link

Time zone and language variables defined in the .env file are not set by default by the application

@Shadow243: Thank you for contributing this: cypht-org/cypht#823

Any wisdom here?

Thanks!

This seems true, we will have to correct it.

https://github.com/cypht-org/cypht/blob/master/lib/config.php#L106
https://github.com/cypht-org/cypht/blob/master/index.php#L34

scripts/upgrade Outdated Show resolved Hide resolved
scripts/install Outdated Show resolved Hide resolved
@marclaporte
Copy link
Contributor

This seems true, we will have to correct it

@Shadow243 Any updates?

@ericgaspar
Copy link
Member Author

!testme

@yunohost-bot
Copy link
Contributor

😜
Test Badge

@yunohost-bot
Copy link
Contributor

📚 🪱
Test Badge

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants