Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove swap requirement #149

Closed
wants to merge 1 commit into from
Closed

Conversation

BDouze
Copy link

@BDouze BDouze commented May 4, 2023

Problem

  • It is not possible to install on a server that does not have swap space even if there is plenty of RAM available.

Solution

  • Remove the checks on swap space

PR Status

  • Code finished and ready to be reviewed/tested
  • The fix/enhancement were manually tested (if applicable)

Automatic tests

Automatic tests can be triggered on https://ci-apps-dev.yunohost.org/ after creating the PR, by commenting "!testme", "!gogogadgetoci" or "By the power of systemd, I invoke The Great App CI to test this Pull Request!". (N.B. : for this to work you need to be a member of the Yunohost-Apps organization)

@JimboJoe
Copy link
Contributor

JimboJoe commented May 4, 2023

Thanks for your proposal. Having a swap is an upstream requirement, so I think it's better to stick to that, so that Discourse support can be provided if needed (and to avoid what was feared initially: random process termination during upgrade).

What could possibly be done to answer your need would be to automatically create that file swap during the installation. I think there are already a couple of packages out there that do just that, aren't there? @YunoHost-Apps/apps-group

@zamentur
Copy link
Contributor

zamentur commented May 14, 2023

On some VPS (using ZFS), it's not possible to create a swap file. I agree if there is a lot of ram we probably should ignore this requirement (upstream says swap file is needed with 1G ram).

@tio-trom
Copy link
Contributor

tio-trom commented Sep 25, 2023

Please either remove this or bring it down to 10. 50 for swapiness is a lot in my view. Even Discord recommends 10 https://meta.discourse.org/t/create-a-swapfile-for-your-linux-server/13880

I moved to a new server where I cannot modify the swapiness and it is 10. So I cannot restore my Discord...

Makes total sense if you have enough RAM to skip this high requirement. I have 40GB of RAM and I cannot install discord because my swapiness is 10....

@tio-trom
Copy link
Contributor

How about doing it like this #161 ?

@Salamandar
Copy link
Member

Closed in favor of #161

@Salamandar Salamandar closed this Mar 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants