[enh/fix] Use ynh_print_* helpers / Upgrade to 0.1.0-beta.7.2 and fix upgrade tests #110
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 6 commits
September 17, 2018 22:06
[enh] Upgrade to 0.1.0-beta.7.2 [fix] Scripts remembers whether Flarum or its extension were upgraded or not. [fix] Bad logic test for Flarum versions comparison
Upgrade to version 0.1.0-beta.7.2
tituspijean
commented
Nov 11, 2018
| if [[ $flarum_version == "0.1.0-beta.7.2"]]; then | ||
| curl "https://$domain$path_url/admin" -H "Accept: */*" --compressed -H "Content-Type: application/x-www-form-urlencoded; charset=UTF-8" --data "databasePassword=$db_pwd" | ||
| if [[ $flarum_version == "0.1.0-beta.7.2" ]]; then | ||
| curl "https://$domain$path_url/admin" -H "Accept: */*" --compressed -H "Content-Type: application/x-www-form-urlencoded; charset=UTF-8" --data "databasePassword=$db_pwd" -k |
There was a problem hiding this comment.
I had to add this -k flag to be able to send the POST request to servers with auto-signed certificates. I consider it low-risk, as the request actually won't leave the server.
tituspijean
changed the title
|
Seems to be fine.I will test this evening. |
This was referenced Dec 1, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
馃悰 This is a security upgrade.
Official documentation about this security fix requires the user to manually enter the password database in the /admin page. As it consists in a simple POST action, I used a curl call to automatically perform it.
鈿狅笍 However, to perform this curl call with auto-signed certificates, I had to add the -k (accept all certificates) to the command. I consider the risk low, as the $domain curl reaches to is hosted by the same server.
While testing, I discovered some overlooks in the upgrade script that I fixed:
I also added the new
ynh_print_*helpers from a previous PR.Closes #105 #102 #108.