Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

13.0.0 #113

Merged
merged 6 commits into from Jun 4, 2020
Merged

13.0.0 #113

merged 6 commits into from Jun 4, 2020

Conversation

kay0u
Copy link
Member

@kay0u kay0u commented May 23, 2020

Solution

PR Status

  • Code finished.
  • Tested with Package_check.
  • Fix or enhancement tested.
  • Upgrade from last version tested.
  • Can be reviewed and tested.

Validation


  • Code review : yalh76
  • Approval (LGTM) : yalh76
    Code review and approval have to be from a member of @YunoHost-Apps/apps-group
  • CI succeeded :
    Build Status
    When the PR is marked as ready to merge, you have to wait for 3 days before really merging it.

@kay0u kay0u marked this pull request as ready for review May 30, 2020 14:38
yalh76
yalh76 previously approved these changes May 30, 2020
Copy link
Member

@yalh76 yalh76 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just made a quick look but LGTM

scripts/upgrade Show resolved Hide resolved
scripts/upgrade Outdated Show resolved Hide resolved
Copy link
Member

@yalh76 yalh76 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kay0u
Copy link
Member Author

kay0u commented Jun 1, 2020

Merging in 3 days

@Christophe31
Copy link

maybe late but a critical security patch issued (13.0.4) https://about.gitlab.com/releases/2020/06/03/critical-security-release-13-0-4-released/
May be relevant.

@kay0u
Copy link
Member Author

kay0u commented Jun 4, 2020

Let's merge that PR, I'll create a new one right after.

@kay0u kay0u merged commit 793ea35 into master Jun 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants