New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
upgrade to 1.20, fix nginx issue, open jsonrpc for kandroid #55
Conversation
tested with package_check, VM upgrade, and personal server upgrade works fine. |
LGTM, code review and upgrade from previous version OK... except for the Kandroid part: I didn't manage to login from Kandroid... |
can we go forward? The connection bug is not related to Kanboard: andresth/Kandroid#38 |
Didn't we need to activate LDAP authentication...? |
Code review OK and LGTM |
Will be merged in 3 days. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wanted just to know, why you removed the maintainer mbugeia ? (I think even if he is not here, we should keep his name, at least to be ok with the copyright allowed by the license). Btw, you can add your name near the other one :) 2 maintainer is ok too. At least it's my point of view.
By the way, it could be really interesting to have a way to keep traces of the previous maintainers. |
if you tell me how to do it, I'll be pleased to add previous maintainer name as an INFO in the manifest.json, but I doubt this file aim to keep historic data. I would rather keep it somewhere else (like Readme, but we don't need structured data for this). |
I opened a issue about that, https://dev.yunohost.org/issues/1095 For the moment, an upgrade of kanboard could be interresting and should not be stopped by that. As this PR has been accepted, I merge it. |
Following our meeting this evening, the idea is to try a new entry in the manifest called "old_maintainers" or "previous_maintainers", which should not causes any trouble to the manifest. |
only tested with package_check, please have a look with real installs, i'll do the same on my server soon
Problem
Solution
PR Status
Obviously, you should really check these affirmations
Work finished. Package_check, basic tests and upgrade from last version OK.
Could be reviewed and tested.
Validation
Minor decision
When the PR is mark as ready to merge, you have to wait for 3 days before really merge it.