Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Install the pdfminer module by default #47

Closed
bnjbvr opened this issue Jan 3, 2020 · 4 comments
Closed

Install the pdfminer module by default #47

bnjbvr opened this issue Jan 3, 2020 · 4 comments

Comments

@bnjbvr
Copy link
Contributor

bnjbvr commented Jan 3, 2020

... so weboob can use it to parse PDFs. Not sure it's actually necessary, but it's nice to have as a bonus feature.
bnjbvr added a commit to bnjbvr/kresus_ynh that referenced this issue Jan 3, 2020
@bnjbvr
Fixes YunoHost-Apps#47: install pdfminer by default
cc87bac
@Jibec Jibec closed this as completed in ada7a4f Jan 3, 2020
Jibec added a commit that referenced this issue Jan 3, 2020
@Jibec
Merge pull request #48 from bnjbvr/install-pdfminer
a78bfe6 
Fixes #47: install pdfminer by default
@lenod
Copy link

lenod commented Jan 6, 2020

I reckon this changed made my last kresus upgrade fail with:
ERROR: Package 'pdfminer' requires a different Python: 3.5.3 not in '>=3.6'

Indeed, python3 has version 3.5.3 on debian stretch, and yunohost doesn't support debian buster yet. Maybe consider allowing the installation of pdfminer to fail?

@Jibec
Copy link
Contributor

Jibec commented Jan 7, 2020 via email

@nicofrand
Copy link
Collaborator

Hi!

Just seeing this issue… I thought pdfminer.six was the one compatible with python3 anyway?

@bnjbvr
Copy link
Contributor Author

bnjbvr commented Jan 7, 2020

Oops, yeah might be necessary to replace it by pdfminer.six then, sorry about this!

@lenod lenod mentioned this issue Jan 13, 2020
Closed
Jibec pushed a commit that referenced this issue Feb 20, 2020
@bnjbvr @Jibec
Fixes #47: install pdfminer by default
a24b897
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@Jibec @bnjbvr @nicofrand @lenod