Bugfix and reimplement Pictrs #76
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
!testme |
|
Alrighty! |
ericgaspar
requested changes
Dec 24, 2023
| @@ -16,8 +16,9 @@ source /usr/share/yunohost/helpers | |||
| #================================================= | |||
| ynh_script_progression --message="Stopping a systemd service..." --weight=1 | |||
|
|
|||
| ynh_systemd_action --service_name=$app --action="stop" --line_match="Stopped" --log_path=systemd | |||
| ynh_systemd_action --service_name=$app-ui --action="stop" --line_match="Stopped" --log_path=systemd | |||
| ynh_systemd_action --service_name=$app --action="stop" --line_match="Stopped" "/var/log/$app/$app.log" | |||
There was a problem hiding this comment.
Suggested change
| ynh_systemd_action --service_name=$app --action="stop" --line_match="Stopped" "/var/log/$app/$app.log" | |
| ynh_systemd_action --service_name=$app --action="stop" --line_match="Stopped" --log_path="/var/log/$app/$app.log" |
There was a problem hiding this comment.
log_path are set to differently in upgrade script --log_path=systemd
There was a problem hiding this comment.
What's the best practice ? Write logs in the file ?
Co-authored-by: eric_G <46165813+ericgaspar@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The current package in master has three problems :
Solution
PR Status
Automatic tests
Automatic tests can be triggered on https://ci-apps-dev.yunohost.org/ after creating the PR, by commenting "!testme", "!gogogadgetoci" or "By the power of systemd, I invoke The Great App CI to test this Pull Request!". (N.B. : for this to work you need to be a member of the Yunohost-Apps organization)