-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updates #9
Conversation
…. Update comments.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's good. But it's better to add an issue for Level 4=1
+ add the URL of the issue in the 'check_process' file.
For the maintainer, perhaps it's better to have the name of the original maintainer of the package somewhere in the manifest or at least in comment (#).
Ok, I will do that.
For the original contributor, his contact is on git commits. For me it's enough. |
Hum, the level 6 is reached only because yunohost return 0 even if the backup and restore are clearly failed ! Also, for official integration, some things are missing.
If you need some help, don't hesitate :) |
Any review on this one? |
After reviewing it, I think @maniackcrudelis said it all. Moreover as a newer official app, it would be much better (expected?) to comply with the latest template (pending PRs on example_ynh). |
Any approval for this MR? |
I just read the code, but I have already do a check earlier. |
firewall allow
.The app should go level 6 and could pretend official integration.