Global upgrade #43
Merged
Global upgrade #43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Global upgrade
3 tasks
|
We should probably wait for #46, what do you think? |
|
Agree |
alexAubin
requested changes
May 25, 2020
|
Alright I got tired of people reporting issues with this app so I fixed the regenconf hook There's a CI test pending here https://ci-apps-dev.yunohost.org/jenkins/view/aleks/job/my_webapp_ynh%20(aleks)/ I intend to yolomerge this PR if it passes tests |
|
Agreed to merge during today's meeting ... not sure why CI HQ fails but tests are passing on the dev CI ... (though at some point there was the same error). Will see |
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Solution
PR Status
Validation
Minor decision
When the PR is marked as ready to merge, you have to wait for 3 days before really merging it.