Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement LDAP authentication #28

Closed
yalh76 opened this issue Feb 7, 2019 · 7 comments · Fixed by #99 or #126
Closed

Implement LDAP authentication #28

yalh76 opened this issue Feb 7, 2019 · 7 comments · Fixed by #99 or #126
Assignees
@yalh76
Labels
enhancement New feature or request
Projects
General

Comments

@yalh76
Copy link
Member

yalh76 commented Feb 7, 2019

No description provided.

@yalh76 yalh76 added the enhancement New feature or request label Feb 7, 2019
@yalh76 yalh76 self-assigned this Feb 7, 2019
@yalh76 yalh76 added this to To do in General via automation Feb 7, 2019
@yalh76 yalh76 changed the title Implement LDAP authentification Implement LDAP authentication Feb 8, 2019
@yalh76
Copy link
Member Author

yalh76 commented Feb 12, 2019

No LDAP support for known but maybe in the future:
https://git.pleroma.social/pleroma/pleroma/issues/203

@yalh76 yalh76 closed this as completed Feb 12, 2019
General automation moved this from To do to Done Feb 12, 2019
@yalh76 yalh76 reopened this Feb 12, 2019
General automation moved this from Done to In progress Feb 12, 2019
@yalh76 yalh76 moved this from In progress to Waiting in General Feb 12, 2019
@yalh76 yalh76 moved this from Waiting to In progress in General Mar 17, 2019
@yalh76
Copy link
Member Author

yalh76 commented Mar 17, 2019

Ldap implemented in pleroma
trying to implement it on https://github.com/YunoHost-Apps/pleroma_ynh/tree/ldap

@yalh76
Copy link
Member Author

yalh76 commented Mar 18, 2019

ldap only available in the develop branch for now

@yalh76 yalh76 moved this from In progress to To do in General Mar 18, 2019
@yalh76 yalh76 moved this from To do to Waiting in General Mar 18, 2019
This was referenced May 1, 2019
Closed
Closed
Closed
@Thatoo
Copy link

Thatoo commented May 13, 2019

I have modified README.md to include the LDAP support as you can see here https://github.com/Thatoo/pleroma_ynh but I can't make a PR from my master branch to your testing branch (only to your master).
I know it is available only on testing branch so I don't want to make a PR to master for now.
Is it possible to do so or should I wait that you finish testing and that you merge your testing branch into your master branch?

@yalh76
Copy link
Member Author

yalh76 commented May 13, 2019

I have modified README.md to include the LDAP support as you can see here https://github.com/Thatoo/pleroma_ynh but I can't make a PR from my master branch to your testing branch (only to your master).
I know it is available only on testing branch so I don't want to make a PR to master for now.
Is it possible to do so or should I wait that you finish testing and that you merge your testing branch into your master branch?

It's because you made the changes in the master branch of your fork. Would be better to do in the Testing Branch

two options:

  1. you merge https://github.com/YunoHost-Apps/pleroma_ynh/tree/testing into https://github.com/Thatoo/pleroma_ynh and then you would be able to to do a PR from https://github.com/Thatoo/pleroma_ynh to https://github.com/YunoHost-Apps/pleroma_ynh/tree/testing (best option)
  2. You redo all the changes you want into https://github.com/Thatoo/pleroma_ynh/tree/testing and then make a PR to https://github.com/YunoHost-Apps/pleroma_ynh/tree/testing

But at the end of the day, if we say in the readme that ldap is supported, we need to explain how or to implement it automatically in the package.

For ending, actual pleroma_ynh is based on pleroma v0.9.9999, and pleroma v0.9.9999 don't support ldap.
Ldap in for now in the develop branch of pleroma and has not been released.

@Thatoo
Copy link

Thatoo commented May 14, 2019

Thank you, I understand. I mean I think I understand...

And I guess it will wait till LDAP is supported by pleroma.

@brickcamp brickcamp mentioned this issue Jun 12, 2019
Closed
@yalh76 yalh76 moved this from Waiting to To do in General Aug 13, 2019
@yalh76 yalh76 moved this from To do to In progress in General Aug 13, 2019
@yalh76 yalh76 mentioned this issue Aug 13, 2019
Closed
14 tasks
@yalh76 yalh76 mentioned this issue Dec 28, 2019
Merged
12 tasks
@yalh76 yalh76 mentioned this issue Jan 12, 2020
Merged
6 tasks
This was linked to pull requests May 29, 2020
ldap #99
Merged
Integrate LDAP #126
Merged
@yalh76
Copy link
Member Author

yalh76 commented Jun 3, 2020

Ldap implemented

@yalh76 yalh76 closed this as completed Jun 3, 2020
General automation moved this from In progress to Done Jun 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@yalh76 yalh76

Labels
enhancement New feature or request
Projects
General
  
Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

ldap YunoHost-Apps/pleroma_ynh
Integrate LDAP YunoHost-Apps/pleroma_ynh
2 participants
@Thatoo @yalh76