Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Package upgrade #56

Merged
merged 3 commits into from May 26, 2019
Merged

Package upgrade #56

merged 3 commits into from May 26, 2019

Conversation

maniackcrudelis
Copy link

@maniackcrudelis maniackcrudelis commented May 18, 2019 •
edited by JimboJoe

Problem

  • Global upgrade of the package.
  • Use fail2ban

PR Status

  • Code finished.
  • Tested with Package_check.
  • Fix or enhancement tested.
  • Upgrade from last version tested.
  • Can be reviewed and tested.

Validation

Minor decision

  • Upgrade previous version :
  • Code review : Kay0u
  • Approval (LGTM) : Kay0u
  • Approval (LGTM) : JimboJoe
  • CI succeeded :
    Build Status
    When the PR is marked as ready to merge, you have to wait for 3 days before really merging it.

@maniackcrudelis maniackcrudelis requested a review from a team May 18, 2019 14:50
kay0u
kay0u approved these changes May 22, 2019
View reviewed changes
Copy link
Member

@kay0u kay0u left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM & code review

@kay0u kay0u mentioned this pull request May 22, 2019
Merged
8 tasks
JimboJoe
JimboJoe approved these changes May 22, 2019
View reviewed changes
Copy link

@JimboJoe JimboJoe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@JimboJoe
Copy link

Can be merged in 3 days.

@maniackcrudelis maniackcrudelis merged commit aabd61c into testing May 26, 2019
@maniackcrudelis maniackcrudelis deleted the package_upgrade branch May 26, 2019 10:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JimboJoe JimboJoe JimboJoe approved these changes

@kay0u kay0u kay0u approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@maniackcrudelis @JimboJoe @kay0u