Upgrade to upstream version 0.12.0 #16
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Just 2 questions:
Anyway, I like your template for this PR. Maybe it's can be our official template. We need one, by the way... So, I tried a "real" install on my VM, it works fine. |
maniackcrudelis
approved these changes
Jul 23, 2017
|
As discussed on XMPP, it seems better to apply the complete process in the apps themselves, and then merge quickly the PR on official/community.json. So let's move on! |
JimboJoe
requested review from
Psycojoker,
magikcypress,
julienmalik,
zamentur,
M5oul,
scith,
mbugeia and
polytan02
|
If you don't mind, I slightlied change your the validation points. It seems more specific to the apps. |
frju365
approved these changes
Aug 15, 2017
|
Obsoleted by #21 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Upgrade to new Searx 0.12.0
Solution
Update upstream archive reference and adapt setting file.
PR Status
Work finished. Package_check, basic tests and upgrade from last version OK.
Could be reviewed and tested.
Validation
[ ] Principle agreement 0/2 :[ ] Quick review 0/1 :[ ] Simple test 0/1 :[ ] Deep review 0/1 :[ ] Complex test 0/0Complete test :Upgrade previous version :Code review : Maniack CApproval (LGTM) : Maniack CApproval (LGTM) : frju365CI succeeded : Maniack CSince this PR has been rerouted from master to testing. It passes to a minor decision.
When the PR is mark as ready to merge, you have to wait for 3 days before really merge it.