Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update to 0.15.0 #52

Merged
merged 4 commits into from
Aug 5, 2019
Merged

Update to 0.15.0 #52

merged 4 commits into from
Aug 5, 2019

Conversation

liberodark
Copy link
Member

@liberodark liberodark commented Jul 28, 2019 •
edited by kay0u
Loading

Problem

  • Description of why you made this PR

Solution

  • And how you fix that

PR Status

  • Code finished.
  • Tested with Package_check.
  • Fix or enhancement tested.
  • Upgrade from last version tested.
  • Can be reviewed and tested.

Validation

Minor decision

  • Upgrade previous version :
  • Code review : Maniack C
  • Approval (LGTM) : Maniack C
  • Approval (LGTM) : Kay0u
  • CI succeeded :
    Build Status
    When the PR is marked as ready to merge, you have to wait for 3 days before really merging it.

@maniackcrudelis maniackcrudelis changed the base branch from master to testing July 30, 2019 17:41
@maniackcrudelis maniackcrudelis requested a review from a team July 30, 2019 17:47
@maniackcrudelis
Copy link

Code review OK.
Thought an upgrade to python 3 was needed for this upgrade. But it works without.

kay0u
kay0u approved these changes Jul 30, 2019
View reviewed changes
Copy link
Member

@kay0u kay0u left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can be merged in 3 days

@maniackcrudelis maniackcrudelis merged commit 1809e77 into YunoHost-Apps:testing Aug 5, 2019
@AkselRocks AkselRocks mentioned this pull request Sep 3, 2019
Closed
@maniackcrudelis maniackcrudelis mentioned this pull request Dec 6, 2019
Closed
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kay0u kay0u kay0u approved these changes

@maniackcrudelis maniackcrudelis maniackcrudelis approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@liberodark @maniackcrudelis @kay0u