Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[fix] Quick fix upgrade #45

Merged
merged 1 commit into from Dec 21, 2017
Merged

[fix] Quick fix upgrade #45

merged 1 commit into from Dec 21, 2017

Conversation

maniackcrudelis
Copy link
Contributor

@maniackcrudelis maniackcrudelis commented Dec 18, 2017 •
edited

Problem

  • The previous backup script try to backup the cron file. Which be removed just before the backup in the current upgrade script.

Solution

  • Remove the cron file, AFTER the backup. To avoid to crash the backup script.

PR Status

Work finished. Package_check, basic tests and upgrade from last version OK.
Could be reviewed and tested.
Exceptionally, this PR is made from the master branch, to merge and fix that quickly

Validation

Minor decision

  • Upgrade previous version : JimboJoe
  • Code review : JimboJoe
  • Approval (LGTM) : JimboJoe
  • Approval (LGTM) :
  • CI succeeded : Build Status
    When the PR is mark as ready to merge, you have to wait for 3 days before really merge it.

@maniackcrudelis maniackcrudelis requested a review from a team December 18, 2017 11:17
@maniackcrudelis maniackcrudelis mentioned this pull request Dec 18, 2017
Closed
JimboJoe
JimboJoe approved these changes Dec 18, 2017
View reviewed changes
Copy link
Contributor

@JimboJoe JimboJoe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, code review and upgrade from previous version OK 👍

@maniackcrudelis
Copy link
Contributor Author

Let's merge in master in 3 days.

@maniackcrudelis maniackcrudelis merged commit 7e22b29 into master Dec 21, 2017
@maniackcrudelis maniackcrudelis deleted the quick_fix_upgrade branch December 21, 2017 18:15
@maniackcrudelis maniackcrudelis mentioned this pull request Dec 21, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JimboJoe JimboJoe JimboJoe approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@maniackcrudelis @JimboJoe