Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Testing | Packaging v2 + generate config during upgrade + Add hook scripts #117

Merged
merged 69 commits into from Apr 7, 2024

Conversation

alexAubin
Copy link
Member

@alexAubin alexAubin commented Nov 19, 2023

@alexAubin
Copy link
Member Author

!testme

@yunohost-bot
Copy link
Contributor

Meow 🐈
Test Badge

@alexAubin alexAubin changed the title Testing | Generate config during upgrade Testing | Generate config during upgrade + hook to set/unset ipv6 addr Nov 19, 2023
@alexAubin
Copy link
Member Author

!testme

@yunohost-bot
Copy link
Contributor

Alrighty!
Test Badge

@alexAubin
Copy link
Member Author

(can't approve my own PR but LGTM)

@hidrarga
Copy link
Contributor

I noticed that the VPN wasn't restarted after upgrade, here are the logs:

  - Nov 19 22:55:21 systemd[1]: Stopping YunoHost VPN Client....
  - Nov 19 22:55:21 ynh-vpnclient[27023]: [INFO] Retrieving Yunohost settings...
  - Nov 19 22:55:21 ynh-vpnclient[27072]: [ OK ] Settings retrieved
  - Nov 19 22:55:21 ynh-vpnclient[27074]: [INFO] [vpnclient] Stopping...
  - Nov 19 22:55:21 ynh-vpnclient[27088]: [INFO] Cleaning vpnclient custom rules from the firewall
  - Nov 19 22:55:21 ynh-vpnclient[27091]: [INFO] Restarting yunohost firewall...
  - Nov 19 22:55:39 ynh-vpnclient[27092]: Another YunoHost command is running right now, we are waiting for it to finish before running this one
  - Nov 19 22:56:24 ynh-vpnclient[27092]: Still waiting...
  - Nov 19 22:56:51 systemd[1]: ynh-vpnclient.service: Stopping timed out. Terminating.
  - Nov 19 22:56:51 systemd[1]: ynh-vpnclient.service: Control process exited, code=killed, status=15/TERM
  - Nov 19 22:56:51 systemd[1]: ynh-vpnclient.service: Failed with result 'timeout'.
  - Nov 19 22:56:51 systemd[1]: Stopped YunoHost VPN Client..
  - Nov 19 22:56:51 systemd[1]: ynh-vpnclient.service: Consumed 3.591s CPU time.
  - Nov 19 22:56:51 systemd[1]: Starting YunoHost VPN Client....
  - Nov 19 22:56:51 ynh-vpnclient[27265]: [INFO] Retrieving Yunohost settings...
  - Nov 19 22:56:51 ynh-vpnclient[27314]: [ OK ] Settings retrieved
  - Nov 19 22:56:52 ynh-vpnclient[27338]: [INFO] Service is already running
  - Nov 19 22:56:52 systemd[1]: Finished YunoHost VPN Client..

@hidrarga hidrarga changed the title Testing | Generate config during upgrade + hook to set/unset ipv6 addr Testing | Generate config during upgrade + Add hook scripts Jan 2, 2024
@hidrarga
Copy link
Contributor

hidrarga commented Jan 2, 2024

!testme

@yunohost-bot
Copy link
Contributor

Meow 🐈
Test Badge

@alexAubin
Copy link
Member Author

@hidrarga : can't approve my own PR but LGTM, shall we merge this ? There's also #120 which could be merged/released now or later

@alexAubin alexAubin changed the title Testing | Generate config during upgrade + Add hook scripts Testing | Packaging v2 + generate config during upgrade + Add hook scripts Jan 31, 2024
@alexAubin
Copy link
Member Author

!testme

@yunohost-bot
Copy link
Contributor

🚀
Test Badge

@hidrarga
Copy link
Contributor

@hidrarga : can't approve my own PR but LGTM, shall we merge this ? There's also #120 which could be merged/released now or later

I noticed some bug when the VPN disconnects : the client is failing in a loop, because it can't resolve anymore the DNS of the VPN server... I'd like to do some more testing to understand what's causing this, and hopefully solve it.

@hidrarga
Copy link
Contributor

hidrarga commented Apr 7, 2024

@hidrarga : can't approve my own PR but LGTM, shall we merge this ? There's also #120 which could be merged/released now or later

I noticed some bug when the VPN disconnects : the client is failing in a loop, because it can't resolve anymore the DNS of the VPN server... I'd like to do some more testing to understand what's causing this, and hopefully solve it.

I was able to reproduce the bug a couple of months ago, but now that I had (finally) time to test it further, I'm unable to reproduce the bug... So I'd say let's merge, maybe the problem has been solved magically 🤷

@hidrarga hidrarga merged commit c86c653 into master Apr 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

4 participants